Issue 8898016: Added HTTP DELETE request type to content:URLFetcher.

Issue 8898016: Added HTTP DELETE request type to content:URLFetcher. (Closed)

Created:
9 years ago by zel

Modified:
9 years ago

Reviewers:
wtc, jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam, dpranke-watch+content_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Added HTTP DELETE request type to content:URLFetcher. BUG=chromium-os:24126 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114295

Patch Set 7 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	content/common/net/url_fetcher_impl.cc	View	1 2 3 4 5	1 chunk	+4 lines, -0 lines	0 comments	Download
	M	content/public/common/url_fetcher.h	View	1 2 3 4 5 6	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/8898016/1

9 years ago (2011-12-13 18:16:36 UTC) #4

commit-bot: I haz the power

Try job failure for 8898016-1 (retry) on win_rel for step "compile" (clobber build). It's a ...

9 years ago (2011-12-13 18:36:46 UTC) #5

zel

http://codereview.chromium.org/8898016/diff/11001/content/public/common/url_fetcher.h File content/public/common/url_fetcher.h (right): http://codereview.chromium.org/8898016/diff/11001/content/public/common/url_fetcher.h#newcode77 content/public/common/url_fetcher.h:77: DELETE_REQUEST, // DELETE macro is already taken on Windows ...

9 years ago (2011-12-13 20:10:50 UTC) #6

wtc

Patch Set 5 LGTM. You need to update url_fetcher_impl.cc as well. http://codereview.chromium.org/8898016/diff/2003/content/common/net/url_fetcher_impl.cc File content/common/net/url_fetcher_impl.cc (right): ...

9 years ago (2011-12-13 20:20:06 UTC) #7

zel

http://codereview.chromium.org/8898016/diff/2003/content/common/net/url_fetcher_impl.cc File content/common/net/url_fetcher_impl.cc (right): http://codereview.chromium.org/8898016/diff/2003/content/common/net/url_fetcher_impl.cc#newcode817 content/common/net/url_fetcher_impl.cc:817: case DELETE: On 2011/12/13 20:20:06, wtc wrote: > > ...

9 years ago (2011-12-13 20:25:53 UTC) #8

Patch Set 7 LGTM.

Expand Messages | Collapse Messages