Issue 8898009: Revert 113804 - [filebrowser] Add left panel with roots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8898009: Revert 113804 - [filebrowser] Add left panel with roots. (Closed)

Created:
9 years ago by Evan Stade

Modified:
9 years ago

Reviewers:
dgozman

CC:
chromium-reviews, jstritar+watch_chromium.org, achuith+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 113804 - [filebrowser] Add left panel with roots. Not the final UI yet. Additional improvements: - file name is selected in save-as dialog at start; - new folder moved to context menu, button deleted. BUG=chromium-os:20168, chromium-os:22106, chromium-os:22105, chromium-os:22032, chromium-os:20547, chromium-os:20549 TEST=Manual Review URL: http://codereview.chromium.org/8554003 TBR=dgozman@chromium.org seems to have broken Linux Chromeos bot: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromeOS/builds/2359/steps/browser_tests/logs/stdio Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113841

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+302 lines, -632 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+3 lines, -0 lines	0 comments	Download
MM	chrome/browser/extensions/extension_file_browser_private_api.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/component_extension_resources.grd	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/file_manager/css/file_manager.css	View	5 chunks	+11 lines, -172 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager.js	View	35 chunks	+233 lines, -393 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/harness.js	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/mock_chrome.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/main.html	View	1 chunk	+44 lines, -54 lines	0 comments	Download
M	chrome/browser/resources/file_manager/manifest.json	View	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages