Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Unified Diff: net/spdy/spdy_protocol_test.cc

Issue 8898003: Deprecate SpdyControlFrame::size in favor of SpdyControlFrame::kHeaderSize (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_protocol.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_protocol_test.cc
diff --git a/net/spdy/spdy_protocol_test.cc b/net/spdy/spdy_protocol_test.cc
index 871ef21072f0631c9b290b831e9201ab01afc012..46dd5f071f335e992d80ea5380321f2082b0ae16 100644
--- a/net/spdy/spdy_protocol_test.cc
+++ b/net/spdy/spdy_protocol_test.cc
@@ -50,7 +50,7 @@ namespace {
TEST(SpdyProtocolTest, ProtocolConstants) {
EXPECT_EQ(8u, SpdyFrame::kHeaderSize);
EXPECT_EQ(8u, SpdyDataFrame::size());
- EXPECT_EQ(8u, SpdyControlFrame::size());
+ EXPECT_EQ(8u, SpdyControlFrame::kHeaderSize);
EXPECT_EQ(18u, SpdySynStreamControlFrame::size());
EXPECT_EQ(14u, SpdySynReplyControlFrame::size());
EXPECT_EQ(16u, SpdyRstStreamControlFrame::size());
@@ -265,7 +265,7 @@ TEST(SpdyProtocolTest, TestSpdySettingsFrame) {
}
TEST(SpdyProtocolTest, HasHeaderBlock) {
- SpdyControlFrame frame(SpdyControlFrame::size());
+ SpdyControlFrame frame(SpdyControlFrame::kHeaderSize);
for (SpdyControlType type = SYN_STREAM;
type < NUM_CONTROL_FRAME_TYPES;
type = static_cast<SpdyControlType>(type + 1)) {
@@ -308,7 +308,7 @@ TEST(SpdyProtocolDeathTest, TestDataFrame) {
TEST(SpdyProtocolDeathTest, TestSpdyControlFrameStreamId) {
SpdyControlFrame frame_store(SpdySynStreamControlFrame::size());
- memset(frame_store.data(), '1', SpdyControlFrame::size());
+ memset(frame_store.data(), '1', SpdyControlFrame::kHeaderSize);
SpdySynStreamControlFrame* frame =
reinterpret_cast<SpdySynStreamControlFrame*>(&frame_store);
@@ -324,7 +324,7 @@ TEST(SpdyProtocolDeathTest, TestSpdyControlFrameStreamId) {
TEST(SpdyProtocolDeathTest, TestSpdyControlFrameVersion) {
const unsigned int kVersionMask = 0x7fff;
SpdyControlFrame frame(SpdySynStreamControlFrame::size());
- memset(frame.data(), '1', SpdyControlFrame::size());
+ memset(frame.data(), '1', SpdyControlFrame::kHeaderSize);
// Set the version to various values, and make sure it does not affect the
// type.
@@ -343,8 +343,8 @@ TEST(SpdyProtocolDeathTest, TestSpdyControlFrameVersion) {
}
TEST(SpdyProtocolDeathTest, TestSpdyControlFrameType) {
- SpdyControlFrame frame(SpdyControlFrame::size());
- memset(frame.data(), 255, SpdyControlFrame::size());
+ SpdyControlFrame frame(SpdyControlFrame::kHeaderSize);
+ memset(frame.data(), 255, SpdyControlFrame::kHeaderSize);
// type() should be out of bounds.
EXPECT_FALSE(frame.AppearsToBeAValidControlFrame());
« no previous file with comments | « net/spdy/spdy_protocol.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698