Issue 8897026: Reland r113263 rebased after revert of r113249.

Issue 8897026: Reland r113263 rebased after revert of r113249. (Closed)

Created:
9 years ago by James Hawkins

Modified:
9 years ago

Reviewers:
csilv, ajwong, awong

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Reland r113263 rebased after revert of r113249. base::Bind: Convert chrome_benchmarking_message_filter.cc. BUG=none TEST=none R=csilv,ajwong Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114072

Patch Set 1 #

Total comments: 2

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -21 lines)			Patch
M	chrome/browser/chrome_benchmarking_message_filter.cc	View	5 chunks	+27 lines, -21 lines	2 comments	Download
M	net/disk_cache/backend_impl.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/disk_cache/backend_impl.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	net/disk_cache/disk_cache.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/disk_cache/in_flight_backend_io.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/disk_cache/in_flight_backend_io.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	net/disk_cache/mem_backend_impl.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/disk_cache/mem_backend_impl.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	net/http/mock_http_cache.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/http/mock_http_cache.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

awong

http://codereview.chromium.org/8897026/diff/1/chrome/browser/chrome_benchmarking_message_filter.cc File chrome/browser/chrome_benchmarking_message_filter.cc (right): http://codereview.chromium.org/8897026/diff/1/chrome/browser/chrome_benchmarking_message_filter.cc#newcode27 chrome/browser/chrome_benchmarking_message_filter.cc:27: ClearCacheHelper(ChromeBenchmarkingMessageFilter* filter, Can this be reduced to just a ...

9 years ago (2011-12-12 18:52:57 UTC) #2

James Hawkins

9 years ago (2011-12-12 20:40:22 UTC) #4

http://codereview.chromium.org/8897026/diff/1/chrome/browser/chrome_benchmark...
File chrome/browser/chrome_benchmarking_message_filter.cc (right):

http://codereview.chromium.org/8897026/diff/1/chrome/browser/chrome_benchmark...
chrome/browser/chrome_benchmarking_message_filter.cc:27:
ClearCacheHelper(ChromeBenchmarkingMessageFilter* filter,
On 2011/12/12 18:52:58, awong wrote:
> Can this be reduced to just a single function that you bind?

No, the callback being used is a CompletionCallback, so I can't bind the extra
parameters and have the same type.

Expand Messages | Collapse Messages