Issue 8897025: MIPS: Hydrogen support for context allocated harmony bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8897025: MIPS: Hydrogen support for context allocated harmony bindings. (Closed)

Created:
9 years ago by kalmard

Modified:
9 years ago

Reviewers:
kisg, Paul Lind, Steven, danno

CC:
v8-dev

Visibility:
Public.

More Reviews

Description

MIPS: Hydrogen support for context allocated harmony bindings. Port r10220 (1dae466). Original commit message: This CL adds support for loading from and storing to context slots belonging to harmony let or const bound variables. Checks for the hole value are performed and the function is deoptimized if they fail. The full-codegen generated code will take care of properly throwing a reference error in these cases. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=10235

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -2 lines)			Patch
	M	src/mips/lithium-codegen-mips.cc	View		2 chunks	+10 lines, -0 lines	0 comments	Download
	M	src/mips/lithium-mips.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kalmard

Building v8 on MIPS requires the following patch to be landed first: http://codereview.chromium.org/8896022/

9 years ago (2011-12-10 13:35:10 UTC) #1

LGTM. Will land it for you.

Expand Messages | Collapse Messages