Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 8897015: Fix invalid pointer indirection causing crash when syncing data. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Applied comments. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 094a028fdd298b844d0492595e57cf750f666771..56cf5249c2654faef4ac1f74bc44ab9f13c3bd4c 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -1500,13 +1500,13 @@ void ExtensionService::SetIsIncognitoEnabled(
extension_prefs_->SetIsIncognitoEnabled(extension_id, enabled);
- bool extension_is_enabled = extensions_.Contains(extension->id());
+ bool extension_is_enabled = extensions_.Contains(extension_id);
// When we reload the extension the ID may be invalidated if we've passed it
// by const ref everywhere. Make a copy to be safe.
std::string id = extension_id;
if (extension_is_enabled)
- ReloadExtension(extension->id());
+ ReloadExtension(id);
// Reloading the extension invalidates the |extension| pointer.
extension = GetInstalledExtension(id);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698