chrome/browser/extensions/extension_service.cc - Issue 8897015: Fix invalid pointer indirection causing crash when syncing data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 8897015: Fix invalid pointer indirection causing crash when syncing data. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_service.cc

diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc

index 094a028fdd298b844d0492595e57cf750f666771..d85f0e61cb67f5d96f0deb21cafc2a512328e2a0 100644

--- a/chrome/browser/extensions/extension_service.cc

+++ b/chrome/browser/extensions/extension_service.cc

@@ -1500,7 +1500,8 @@ void ExtensionService::SetIsIncognitoEnabled(

extension_prefs_->SetIsIncognitoEnabled(extension_id, enabled);

- bool extension_is_enabled = extensions_.Contains(extension->id());

Yoyo Zhou 2011/12/09 22:01:23 I believe extension->id() should be extension_id (

+ bool extension_is_enabled = extension ?

+ extensions_.Contains(extension->id()) : false;

// When we reload the extension the ID may be invalidated if we've passed it

// by const ref everywhere. Make a copy to be safe.

« no previous file with comments | « no previous file | no next file » | no next file with comments »