Fix invalid pointer indirection causing crash when syncing data.

Fix invalid pointer indirection causing crash when syncing data.


BUG=107024
TEST=sync data

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113849

[Yoyo Zhou, 2011-12-09 22:01:23]

http://codereview.chromium.org/8897015/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_service.cc (left):

http://codereview.chromium.org/8897015/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_service.cc:1503: bool extension_is_enabled =
extensions_.Contains(extension->id());
I believe extension->id() should be extension_id (which is the argument to this
function).

http://codereview.chromium.org/8897015/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_service.cc:1509:
ReloadExtension(extension->id());
Same here -- although if we get here then extension must have been valid, it
still seems safer to use extension_id.

[miket_OOO, 2011-12-09 22:07:13]

lgtm

[Emmanuel Saint-loubert-Bié, 2011-12-09 22:08:21]

I will apply the fixes and TBR it

On Fri, Dec 9, 2011 at 2:07 PM,  <miket@chromium.org> wrote:
> lgtm
>
>
>
> http://codereview.chromium.org/8897015/

[Yoyo Zhou, 2011-12-09 22:10:15]

On 2011/12/09 22:08:21, Emmanuel Saint-loubert wrote:
> I will apply the fixes and TBR it
> 
> On Fri, Dec 9, 2011 at 2:07 PM,  <mailto:miket@chromium.org> wrote:
> > lgtm
> >
> >
> >
> > http://codereview.chromium.org/8897015/

LGTM