GTK: Remove deprecated methods and replace them with the new standard calls.

GTK: Remove deprecated methods and replace them with the new standard calls.

BUG=79722
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113893

[Elliot Glaysher, 2011-12-09 19:10:30]

Even more gtk3 preperation

[Lei Zhang, 2011-12-09 20:57:33]

http://codereview.chromium.org/8897006/diff/1/chrome/browser/ui/gtk/tabs/tab_...
File chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc (right):

http://codereview.chromium.org/8897006/diff/1/chrome/browser/ui/gtk/tabs/tab_...
chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc:8: #include <gtk/gtk.h>
nit: C includes before C++ includes.

http://codereview.chromium.org/8897006/diff/1/ui/base/gtk/gtk_compat.h
File ui/base/gtk/gtk_compat.h (right):

http://codereview.chromium.org/8897006/diff/1/ui/base/gtk/gtk_compat.h#newcode32
ui/base/gtk/gtk_compat.h:32: inline void gtk_widget_set_mapped(GtkWidget*
widget) {
Doesn't gtk_widget_set_mapped() also take a gboolean? Ditto for set_realized
below.

[Elliot Glaysher, 2011-12-09 21:18:21]

Yes it does. Overlooked that. PTAL.

[Lei Zhang, 2011-12-09 21:47:03]

lgtm

[commit-bot: I haz the power, 2011-12-09 21:49:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/8897006/1014

[commit-bot: I haz the power, 2011-12-09 21:49:31]

Can't apply patch for file chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc.
While running patch -p1 --forward --force;
patching file chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc
Hunk #1 succeeded at 4 with fuzz 2.
Hunk #2 FAILED at 781.
Hunk #3 succeeded at 930 (offset 1 line).
Hunk #4 FAILED at 1727.
Hunk #5 FAILED at 1781.
Hunk #6 FAILED at 1809.
Hunk #7 FAILED at 1867.
5 out of 7 hunks FAILED -- saving rejects to file
chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc.rej

[commit-bot: I haz the power, 2011-12-09 22:18:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/8897006/2002

[commit-bot: I haz the power, 2011-12-09 22:18:36]

Presubmit check for 8897006-2002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
webkit/plugins/npapi/gtk_plugin_container_manager.cc,ui/gfx/gtk_preserve_window.cc

Presubmit checks took 1.9s to calculate.

[Elliot Glaysher, 2011-12-09 22:19:34]

+tony and +sky for OWNERS stamps on webkit/ and ui/ respectively.

[tony, 2011-12-09 22:23:44]

LGTM

[sky, 2011-12-09 22:37:07]

LGTM

[commit-bot: I haz the power, 2011-12-09 22:37:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/8897006/2002

[commit-bot: I haz the power, 2011-12-10 00:21:05]

Change committed as 113893