Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 8897002: Fix an issue where the first profile desktop shortcut gets the correct arguments. (Closed)

Created:
9 years ago by SteveT
Modified:
9 years ago
Reviewers:
sail
CC:
chromium-reviews
Visibility:
Public.

Description

Fix an issue where the first profile desktop shortcut gets the correct arguments. BUG=106951 TEST=With a fresh Chrome, create a second profile. Ensure that the original shortcut is modified to point to the first profile. If you check the shortcut, the argument to chrome.exe should include something like --profile-directory="Default". Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113836

Patch Set 1 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/profiles/profile_shortcut_manager_win.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
SteveT
PTAL. I think Miranda just missed a call when she landed her initial patch :) ...
9 years ago (2011-12-09 16:13:16 UTC) #1
sail
lgtm
9 years ago (2011-12-09 17:45:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevet@chromium.org/8897002/3001
9 years ago (2011-12-09 17:46:54 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-09 19:38:25 UTC) #4
Change committed as 113836

Powered by Google App Engine
This is Rietveld 408576698