Issue 8896023: Fixed the value of "controlledBy" for preferences when they're set by the user.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8896023: Fixed the value of "controlledBy" for preferences when they're set by the user. (Closed)

Created:
9 years ago by Joao da Silva

Modified:
9 years ago

Reviewers:
Mattias Nissler (ping if slow)

CC:
chromium-reviews, Paweł Hajdan Jr., James Hawkins, Bernhard Bauer

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fixed the value of "controlledBy" for preferences when they're set by the user. BUG=107098, 106592 TEST=unit_tests:PrefValueStoreTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114009

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -2 lines)			Patch
M	chrome/browser/prefs/pref_service.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/prefs/pref_service.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/prefs/pref_value_store.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/prefs/pref_value_store.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/prefs/pref_value_store_unittest.cc	View	1 chunk	+21 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/options/core_options_handler.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/8896023/1

9 years ago (2011-12-12 10:06:50 UTC) #3

Change committed as 114009