Issue 8896022: MIPS: Reland 10216 - Optimize the equality check case of ICCompare stubs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8896022: MIPS: Reland 10216 - Optimize the equality check case of ICCompare stubs. (Closed)

Created:
9 years ago by kalmard

Modified:
9 years ago

Reviewers:
kisg, Paul Lind, danno, Rico

CC:
v8-dev

Visibility:
Public.

More Reviews

Description

MIPS: Reland 10216 - Optimize the equality check case of ICCompare stubs. Port r10219 (56686b). Original commit message: Now with arm and x64 support. Additionally, added default unreachable case to switch statement in CompareIC::TargetState to make win and mac compilers happy. Reviewer guide: This is an exact copy of 10216 except: src/arm/* src/x64/* src/ic.cc (added default case to swith in CompareIC::TargetState) BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=10232

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -12 lines)			Patch
	M	src/mips/code-stubs-mips.cc	View		1 chunk	+25 lines, -12 lines	0 comments	Download
	M	src/mips/ic-mips.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM, thanks, I will land it.

Expand Messages | Collapse Messages