Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 8896018: Add a policy pref for the --enable-memory-info flag. (Closed)

Created:
9 years ago by Michael Moss
Modified:
9 years ago
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, Nirnimesh, John Grabowski, brettw-cc_chromium.org, anantha, dyu1, ajwong+watch_chromium.org, dennis_jeffrey, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add a policy pref for the --enable-memory-info flag. BUG=43281 TEST=Setting pref has same effect as running with --enable-memory-info. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114022

Patch Set 1 #

Patch Set 2 : Add missing file with RegisterBooleanPref(). #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
M chrome/app/policy/policy_templates.json View 2 chunks +14 lines, -1 line 1 comment Download
M chrome/browser/policy/configuration_policy_handler_list.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/prefs/command_line_pref_store.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/tab_contents/render_view_host_delegate_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/data/enterprise/chrome.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/enterprise/chrome-reverse.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/functional/policy_prefs_ui.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Michael Moss
This is based heavily on a similar change in http://codereview.chromium.org/8772014/. Please let me know if ...
9 years ago (2011-12-09 23:54:42 UTC) #1
Mattias Nissler (ping if slow)
LGTM once you resolve my question. http://codereview.chromium.org/8896018/diff/3001/chrome/app/policy/policy_templates.json File chrome/app/policy/policy_templates.json (right): http://codereview.chromium.org/8896018/diff/3001/chrome/app/policy/policy_templates.json#newcode2231 chrome/app/policy/policy_templates.json:2231: 'future': True, Is ...
9 years ago (2011-12-12 10:10:58 UTC) #2
Michael Moss
I'm not sure if it will stay for good. Right now we want to do ...
9 years ago (2011-12-12 14:43:14 UTC) #3
Mattias Nissler (ping if slow)
OK, then let's keep it as Future for now, so we don't have it visible ...
9 years ago (2011-12-12 14:44:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmoss@chromium.org/8896018/3001
9 years ago (2011-12-12 14:55:20 UTC) #5
mnaganov (inactive)
On 2011/12/12 14:55:20, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
9 years ago (2011-12-12 15:11:14 UTC) #6
commit-bot: I haz the power
9 years ago (2011-12-12 16:04:35 UTC) #7
Change committed as 114022

Powered by Google App Engine
This is Rietveld 408576698