Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Unified Diff: net/spdy/spdy_network_transaction_unittest.cc

Issue 8896016: Fix use-after-frees in some SPDY tests. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_network_transaction_unittest.cc
diff --git a/net/spdy/spdy_network_transaction_unittest.cc b/net/spdy/spdy_network_transaction_unittest.cc
index 632649b2500bf531b25096aed5dc1fbf4f6d0e87..d0f0d2b7b506c1eaeb61b9b47d44f138b44c3c67 100644
--- a/net/spdy/spdy_network_transaction_unittest.cc
+++ b/net/spdy/spdy_network_transaction_unittest.cc
@@ -4199,8 +4199,8 @@ TEST_P(SpdyNetworkTransactionTest, SettingsSaved) {
"version", "HTTP/1.1"
};
- NormalSpdyTransactionHelper helper(CreateGetRequest(),
- BoundNetLog(), GetParam());
+ BoundNetLog net_log;
+ NormalSpdyTransactionHelper helper(CreateGetRequest(), net_log, GetParam());
helper.RunPreTestSetup();
// Verify that no settings exist initially.
@@ -4310,8 +4310,8 @@ TEST_P(SpdyNetworkTransactionTest, SettingsPlayback) {
"version", "HTTP/1.1"
};
- NormalSpdyTransactionHelper helper(CreateGetRequest(),
- BoundNetLog(), GetParam());
+ BoundNetLog net_log;
+ NormalSpdyTransactionHelper helper(CreateGetRequest(), net_log, GetParam());
helper.RunPreTestSetup();
// Verify that no settings exist initially.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698