Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 8896014: Use displayname for printer name if it is set (Closed)

Created:
9 years ago by Albert Bodenhamer
Modified:
9 years ago
Reviewers:
Scott Byer, dpapad
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Use displayname for printer name if it is set BUG=http://code.google.com/p/chromium-os/issues/detail?id=24025 TEST=If the user sets the name of a printer in cloud print that name should be the displayed name of that printer in the print preview page. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114048

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/resources/print_preview/print_preview_cloud.js View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Albert Bodenhamer
9 years ago (2011-12-09 21:52:20 UTC) #1
Scott Byer
lgtm
9 years ago (2011-12-09 21:55:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abodenha@chromium.org/8896014/1
9 years ago (2011-12-09 21:57:33 UTC) #3
commit-bot: I haz the power
Presubmit check for 8896014-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-12-09 21:57:36 UTC) #4
Albert Bodenhamer
Grrr. Looks like I'll need OWNERS approval. Demetrios, can you look this over when you ...
9 years ago (2011-12-09 23:39:02 UTC) #5
dpapad
On 2011/12/09 23:39:02, Albert Bodenhamer wrote: > Grrr. Looks like I'll need OWNERS approval. > ...
9 years ago (2011-12-09 23:54:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abodenha@chromium.org/8896014/1
9 years ago (2011-12-12 17:41:24 UTC) #7
commit-bot: I haz the power
9 years ago (2011-12-12 18:46:26 UTC) #8
Change committed as 114048

Powered by Google App Engine
This is Rietveld 408576698