Implement onEvent callback framework for UDP

chrome/renderer/resources/extensions/schema_generated_bindings.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This script contains privileged chrome extension related javascript APIs.
 // It is loaded by pages whose URL has the chrome-extension protocol.
 
 var chrome = chrome || {};
 (function() {
+  native function GetChromeHidden();
   native function GetExtensionAPIDefinition();
-  native function StartRequest();
-  native function GetChromeHidden();
   native function GetNextRequestId();
   native function Print();
+  native function StartRequest();
 
+  native function CreateBlob(filePath);
+  native function DecodeJPEG(jpegImage);
   native function GetCurrentPageActions(extensionId);
   native function GetExtensionViews();
+  native function GetLocalFileSystem(name, path);
   native function GetNextContextMenuId();
+  native function GetNextSocketEventId();
   native function GetNextTtsEventId();
+  native function GetRenderViewId();
+  native function GetUniqueSubEventName(eventName);
   native function OpenChannelToTab();
-  native function GetRenderViewId();
+  native function SendResponseAck(requestId);

[miket_OOO, 2011/12/13 22:44:50]

I alphabetized this list of functions and added my one new function
(GetNextSocketEventId). It's possible I violated a code of conduct by doing so
and will be happy to revert, but I do feel it makes this block much more
readable and maintainable.

[Aaron Boodman, 2011/12/14 00:28:23]

I think what you did is perfect. It's nice to cleanup code, but it's also nice
to note what change you actually made in the case that the cleanup makes it
unclear.

   native function SetIconCommon();
-  native function GetUniqueSubEventName(eventName);
-  native function GetLocalFileSystem(name, path);
-  native function DecodeJPEG(jpegImage);
-  native function CreateBlob(filePath);
-  native function SendResponseAck(requestId);
 
   var chromeHidden = GetChromeHidden();
 
   if (!chrome)
     chrome = {};
 
   function forEach(dict, f) {
     for (key in dict) {
       if (dict.hasOwnProperty(key))
         f(key, dict[key]);
@@ skipping 542 matching lines @@
                 delete chromeHidden.tts.handlers[event.srcId];
               }
             }
           });
       } catch (e) {
         // This extension doesn't have permission to access TTS, so we
         // can safely ignore this.
       }
   }
 
+  function setupSocketEvents() {
+    chromeHidden.socket = {};
+    chromeHidden.socket.handlers = {};
+    try {
+      chrome.experimental.socket.onEvent.addListener(
+          function(event) {
+            var eventHandler = chromeHidden.socket.handlers[event.srcId];
+            if (eventHandler) {
+              eventHandler({
+                             type: event.type,
+                             resultCode: event.resultCode,
+                           });
+              if (event.isFinalEvent) {
+                delete chromeHidden.socket.handlers[event.srcId];
+              }
+            }
+          });
+      } catch (e) {

[Aaron Boodman, 2011/12/14 00:28:23]

Indent looks weird.

+        // Safe to ignore.

[Aaron Boodman, 2011/12/14 00:28:23]

That is almost never true :). How about console.error(e).

+      }
+  }
+
   // Get the platform from navigator.appVersion.
   function getPlatform() {
     var platforms = [
       [/CrOS Touch/, "chromeos touch"],
       [/CrOS/, "chromeos"],
       [/Linux/, "linux"],
       [/Mac/, "mac"],
       [/Win/, "win"],
     ];
 
@@ skipping 487 matching lines @@
       var args = arguments;
       if (args.length > 1 && args[1] && args[1].onEvent) {
         var id = GetNextTtsEventId();
         args[1].srcId = id;
         chromeHidden.tts.handlers[id] = args[1].onEvent;
       }
       sendRequest(this.name, args, this.definition.parameters);
       return id;
     };
 
+    apiFunctions["experimental.socket.create"].handleRequest = function() {
+      var args = arguments;
+      if (args.length > 1 && args[1] && args[1].onEvent) {
+        var id = GetNextSocketEventId();
+        args[1].srcId = id;
+        chromeHidden.socket.handlers[id] = args[1].onEvent;
+      }
+      sendRequest(this.name, args, this.definition.parameters);
+      return id;
+    };
+
     if (chrome.test) {
       chrome.test.getApiDefinitions = GetExtensionAPIDefinition;
     }
 
-    setupPageActionEvents(extensionId);
     setupHiddenContextMenuEvent(extensionId);
     setupInputEvents();
     setupOmniboxEvents();
+    setupPageActionEvents(extensionId);
+    setupSocketEvents();
     setupTtsEvents();
   });
 
   if (!chrome.experimental)
     chrome.experimental = {};
 
   if (!chrome.experimental.accessibility)
     chrome.experimental.accessibility = {};
 
   if (!chrome.experimental.speechInput)
     chrome.experimental.speechInput = {};
 
+  if (!chrome.experimental.socket)
+    chrome.experimental.socket = {};
+
   if (!chrome.tts)
     chrome.tts = {};
 
   if (!chrome.ttsEngine)
     chrome.ttsEngine = {};
 
   if (!chrome.experimental.downloads)
     chrome.experimental.downloads = {};
 })();