Fix page zoom for plug-in documents (PDF, etc.)

Fix page zoom for plug-in documents (PDF, etc.)

BUG=106013, 106228
TEST=Verify zoom-in/zoom-out work correctly on PDF documents.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113923

[csilv, 2011-12-09 22:41:15]

+jam for review/owners approval

Hi John,
Here's a new CL which fixes the PDF bug without nearly as much churn. In fact,
I'm pretty happy with the overall result (reduction in code.) I appreciate your
help and attention on this issue. thx! Chris

[jam, 2011-12-10 00:24:29]

lgtm

have you verified that the pdf plugin's zoom controls behave the same way (i.e.
same increments) as using the browser?

[csilv, 2011-12-10 00:41:45]

On 2011/12/10 00:24:29, John Abd-El-Malek wrote:
> lgtm
> 
> have you verified that the pdf plugin's zoom controls behave the same way
(i.e.
> same increments) as using the browser?

Thanks jam!

The PDF plug-in does it's own zooming which does not match Chromiums.  That's
not a technical problem (there's no harm in that happening), but it's not
desired.

I've filed http://crbug.com/107063 to have the PDF plug-in updated.

[jam, 2011-12-10 01:45:42]

On 2011/12/10 00:41:45, csilv wrote:
> On 2011/12/10 00:24:29, John Abd-El-Malek wrote:
> > lgtm
> > 
> > have you verified that the pdf plugin's zoom controls behave the same way
> (i.e.
> > same increments) as using the browser?
> 
> Thanks jam!
> 
> The PDF plug-in does it's own zooming which does not match Chromiums.  That's
> not a technical problem (there's no harm in that happening), but it's not
> desired.

It used to match chrome, and we definitely want it to keep doing that. The zoom
controls in the pdf are there for convenience, but the behavior should be the
same if they use it or go through chrome's controls. That should block this bug,
so I've marked it as such on the issue.

One question: is the other code in this change that's related to the default
zoom for this bug or something else? if it's a cleanup or for a different bug,
please separate it out, since we'll want to merge the smallest change for pdf to
M17.

> 
> I've filed http://crbug.com/107063 to have the PDF plug-in updated.

[csilv, 2011-12-10 02:01:54]

On 2011/12/10 01:45:42, John Abd-El-Malek wrote:
> One question: is the other code in this change that's related to the default
> zoom for this bug or something else? if it's a cleanup or for a different bug,
> please separate it out, since we'll want to merge the smallest change for pdf
to
> M17.

Everything in this CL is specifically for plug-in zoom.