Issue 8896006: Remove all 51 static initializers from ots.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8896006: Remove all 51 static initializers from ots.cc. (Closed)

Created:
9 years ago by Nico

Modified:
9 years ago

Reviewers:
agl

CC:
chromium-reviews

Base URL:
http://ots.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Remove all 51 static initializers from ots.cc. BUG=chromium:94925

Patch Set 1 #

Total comments: 1

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -38 lines)			Patch
	M	src/ots.cc	View		6 chunks	+36 lines, -38 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

http://codereview.chromium.org/8896006/diff/1/src/ots.cc File src/ots.cc (right): http://codereview.chromium.org/8896006/diff/1/src/ots.cc#newcode149 src/ots.cc:149: return tag == TAG('\x00', '\x01', '\x00', '\x00') || The ...

9 years ago (2011-12-09 19:13:30 UTC) #2

LGTM. Landed in ots r76. Needs to be rolled in which I can do if you like.

Expand Messages | Collapse Messages