Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/objects.cc

Issue 8895025: Fix invalid usage of StoreIC_ArrayLength optimization. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Sven Panne. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 8358 matching lines...) Expand 10 before | Expand all | Expand 10 after
8369 return this; 8369 return this;
8370 } 8370 }
8371 8371
8372 8372
8373 void JSArray::Expand(int required_size) { 8373 void JSArray::Expand(int required_size) {
8374 GetIsolate()->factory()->SetElementsCapacityAndLength( 8374 GetIsolate()->factory()->SetElementsCapacityAndLength(
8375 Handle<JSArray>(this), required_size, required_size); 8375 Handle<JSArray>(this), required_size, required_size);
8376 } 8376 }
8377 8377
8378 8378
8379 MaybeObject* JSObject::SetElementsLength(Object* len) { 8379 MaybeObject* JSArray::SetElementsLength(Object* len) {
8380 // We should never end in here with a pixel or external array. 8380 // We should never end in here with a pixel or external array.
8381 ASSERT(AllowsSetElementsLength()); 8381 ASSERT(AllowsSetElementsLength());
8382 return GetElementsAccessor()->SetLength(this, len); 8382 return GetElementsAccessor()->SetLength(this, len);
8383 } 8383 }
8384 8384
8385 8385
8386 Object* Map::GetPrototypeTransition(Object* prototype) { 8386 Object* Map::GetPrototypeTransition(Object* prototype) {
8387 FixedArray* cache = prototype_transitions(); 8387 FixedArray* cache = prototype_transitions();
8388 int number_of_transitions = NumberOfProtoTransitions(); 8388 int number_of_transitions = NumberOfProtoTransitions();
8389 const int proto_offset = 8389 const int proto_offset =
(...skipping 4162 matching lines...) Expand 10 before | Expand all | Expand 10 after
12552 if (break_point_objects()->IsUndefined()) return 0; 12552 if (break_point_objects()->IsUndefined()) return 0;
12553 // Single break point. 12553 // Single break point.
12554 if (!break_point_objects()->IsFixedArray()) return 1; 12554 if (!break_point_objects()->IsFixedArray()) return 1;
12555 // Multiple break points. 12555 // Multiple break points.
12556 return FixedArray::cast(break_point_objects())->length(); 12556 return FixedArray::cast(break_point_objects())->length();
12557 } 12557 }
12558 #endif // ENABLE_DEBUGGER_SUPPORT 12558 #endif // ENABLE_DEBUGGER_SUPPORT
12559 12559
12560 12560
12561 } } // namespace v8::internal 12561 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698