Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Side by Side Diff: src/ia32/macro-assembler-ia32.h

Issue 8895025: Fix invalid usage of StoreIC_ArrayLength optimization. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Sven Panne. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/ic-ia32.cc ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 290 matching lines...) Expand 10 before | Expand all | Expand 10 after
301 301
302 // Expression support 302 // Expression support
303 void Set(Register dst, const Immediate& x); 303 void Set(Register dst, const Immediate& x);
304 void Set(const Operand& dst, const Immediate& x); 304 void Set(const Operand& dst, const Immediate& x);
305 305
306 // Support for constant splitting. 306 // Support for constant splitting.
307 bool IsUnsafeImmediate(const Immediate& x); 307 bool IsUnsafeImmediate(const Immediate& x);
308 void SafeSet(Register dst, const Immediate& x); 308 void SafeSet(Register dst, const Immediate& x);
309 void SafePush(const Immediate& x); 309 void SafePush(const Immediate& x);
310 310
311 // Compare a register against a known root, e.g. undefined, null, true, ... 311 // Compare against a known root, e.g. undefined, null, true, ...
312 void CompareRoot(Register with, Heap::RootListIndex index); 312 void CompareRoot(Register with, Heap::RootListIndex index);
313 void CompareRoot(const Operand& with, Heap::RootListIndex index);
313 314
314 // Compare object type for heap object. 315 // Compare object type for heap object.
315 // Incoming register is heap_object and outgoing register is map. 316 // Incoming register is heap_object and outgoing register is map.
316 void CmpObjectType(Register heap_object, InstanceType type, Register map); 317 void CmpObjectType(Register heap_object, InstanceType type, Register map);
317 318
318 // Compare instance type for map. 319 // Compare instance type for map.
319 void CmpInstanceType(Register map, InstanceType type); 320 void CmpInstanceType(Register map, InstanceType type);
320 321
321 // Check if a map for a JSObject indicates that the object has fast elements. 322 // Check if a map for a JSObject indicates that the object has fast elements.
322 // Jump to the specified label if it does not. 323 // Jump to the specified label if it does not.
(...skipping 605 matching lines...) Expand 10 before | Expand all | Expand 10 after
928 } \ 929 } \
929 masm-> 930 masm->
930 #else 931 #else
931 #define ACCESS_MASM(masm) masm-> 932 #define ACCESS_MASM(masm) masm->
932 #endif 933 #endif
933 934
934 935
935 } } // namespace v8::internal 936 } } // namespace v8::internal
936 937
937 #endif // V8_IA32_MACRO_ASSEMBLER_IA32_H_ 938 #endif // V8_IA32_MACRO_ASSEMBLER_IA32_H_
OLDNEW
« no previous file with comments | « src/ia32/ic-ia32.cc ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698