Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: src/ia32/macro-assembler-ia32.cc

Issue 8895025: Fix invalid usage of StoreIC_ArrayLength optimization. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Sven Panne. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/macro-assembler-ia32.h ('k') | src/ic.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 339 matching lines...) Expand 10 before | Expand all | Expand 10 after
350 } 350 }
351 351
352 352
353 void MacroAssembler::CompareRoot(Register with, Heap::RootListIndex index) { 353 void MacroAssembler::CompareRoot(Register with, Heap::RootListIndex index) {
354 // see ROOT_ACCESSOR macro in factory.h 354 // see ROOT_ACCESSOR macro in factory.h
355 Handle<Object> value(&isolate()->heap()->roots_array_start()[index]); 355 Handle<Object> value(&isolate()->heap()->roots_array_start()[index]);
356 cmp(with, value); 356 cmp(with, value);
357 } 357 }
358 358
359 359
360 void MacroAssembler::CompareRoot(const Operand& with,
361 Heap::RootListIndex index) {
362 // see ROOT_ACCESSOR macro in factory.h
363 Handle<Object> value(&isolate()->heap()->roots_array_start()[index]);
364 cmp(with, value);
365 }
366
367
360 void MacroAssembler::CmpObjectType(Register heap_object, 368 void MacroAssembler::CmpObjectType(Register heap_object,
361 InstanceType type, 369 InstanceType type,
362 Register map) { 370 Register map) {
363 mov(map, FieldOperand(heap_object, HeapObject::kMapOffset)); 371 mov(map, FieldOperand(heap_object, HeapObject::kMapOffset));
364 CmpInstanceType(map, type); 372 CmpInstanceType(map, type);
365 } 373 }
366 374
367 375
368 void MacroAssembler::CmpInstanceType(Register map, InstanceType type) { 376 void MacroAssembler::CmpInstanceType(Register map, InstanceType type) {
369 cmpb(FieldOperand(map, Map::kInstanceTypeOffset), 377 cmpb(FieldOperand(map, Map::kInstanceTypeOffset),
(...skipping 2307 matching lines...) Expand 10 before | Expand all | Expand 10 after
2677 cmp(length, Operand(bitmap_scratch, MemoryChunk::kSizeOffset)); 2685 cmp(length, Operand(bitmap_scratch, MemoryChunk::kSizeOffset));
2678 Check(less_equal, "Live Bytes Count overflow chunk size"); 2686 Check(less_equal, "Live Bytes Count overflow chunk size");
2679 } 2687 }
2680 2688
2681 bind(&done); 2689 bind(&done);
2682 } 2690 }
2683 2691
2684 } } // namespace v8::internal 2692 } } // namespace v8::internal
2685 2693
2686 #endif // V8_TARGET_ARCH_IA32 2694 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/macro-assembler-ia32.h ('k') | src/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698