Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: trychange.py

Issue 8895022: Still send try job status even if test filter is used (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « git_try.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Client-side script to send a try job to the try server. It communicates to 6 """Client-side script to send a try job to the try server. It communicates to
7 the try server by either writting to a svn repository or by directly connecting 7 the try server by either writting to a svn repository or by directly connecting
8 to the server by HTTP. 8 to the server by HTTP.
9 """ 9 """
10 10
(...skipping 767 matching lines...) Expand 10 before | Expand all | Expand 10 after
778 checkouts[0].checkout_root, 778 checkouts[0].checkout_root,
779 root_presubmit, 779 root_presubmit,
780 options.project, 780 options.project,
781 False, 781 False,
782 sys.stdout) 782 sys.stdout)
783 except ImportError: 783 except ImportError:
784 pass 784 pass
785 # If no bot is specified, either the default pool will be selected or the 785 # If no bot is specified, either the default pool will be selected or the
786 # try server will refuse the job. Either case we don't need to interfere. 786 # try server will refuse the job. Either case we don't need to interfere.
787 787
788 # Prevent rietveld updates if we aren't running all the tests.
789 if options.testfilter is not None:
790 options.issue = None
791 options.patchset = None
792
793 # Send the patch. 788 # Send the patch.
794 if options.send_patch: 789 if options.send_patch:
795 # If forced. 790 # If forced.
796 options.send_patch(options) 791 options.send_patch(options)
797 PrintSuccess(options) 792 PrintSuccess(options)
798 return 0 793 return 0
799 try: 794 try:
800 if can_http: 795 if can_http:
801 _SendChangeHTTP(options) 796 _SendChangeHTTP(options)
802 PrintSuccess(options) 797 PrintSuccess(options)
(...skipping 11 matching lines...) Expand all
814 return 1 809 return 1
815 except (gclient_utils.Error, subprocess2.CalledProcessError), e: 810 except (gclient_utils.Error, subprocess2.CalledProcessError), e:
816 print >> sys.stderr, e 811 print >> sys.stderr, e
817 return 1 812 return 1
818 return 0 813 return 0
819 814
820 815
821 if __name__ == "__main__": 816 if __name__ == "__main__":
822 fix_encoding.fix_encoding() 817 fix_encoding.fix_encoding()
823 sys.exit(TryChange(None, None, False)) 818 sys.exit(TryChange(None, None, False))
OLDNEW
« no previous file with comments | « git_try.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698