Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1975)

Unified Diff: chrome/browser/sync/util/enum_set_unittest.cc

Issue 8895008: [Sync] Relax EnumSet semantics for some functions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/util/enum_set.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/util/enum_set_unittest.cc
diff --git a/chrome/browser/sync/util/enum_set_unittest.cc b/chrome/browser/sync/util/enum_set_unittest.cc
index 5e40dd0a40f58dc74fc8a592b7319f0f762b41e0..6a8eecc791d8c7e6d1c7b3203897be50938b010d 100644
--- a/chrome/browser/sync/util/enum_set_unittest.cc
+++ b/chrome/browser/sync/util/enum_set_unittest.cc
@@ -18,6 +18,7 @@ enum TestEnum {
TEST_3,
TEST_4,
TEST_MAX = TEST_4,
+ TEST_5
};
typedef EnumSet<TestEnum, TEST_MIN, TEST_MAX> TestEnumSet;
@@ -108,11 +109,13 @@ TEST_F(EnumSetTest, RetainAll) {
TEST_F(EnumSetTest, Remove) {
TestEnumSet enums(TEST_3, TEST_4);
+ enums.Remove(TEST_0);
enums.Remove(TEST_2);
EXPECT_TRUE(enums.Equals(TestEnumSet(TEST_3, TEST_4)));
enums.Remove(TEST_3);
EXPECT_TRUE(enums.Equals(TestEnumSet(TEST_4)));
enums.Remove(TEST_4);
+ enums.Remove(TEST_5);
EXPECT_TRUE(enums.Empty());
}
@@ -130,10 +133,12 @@ TEST_F(EnumSetTest, Clear) {
TEST_F(EnumSetTest, Has) {
const TestEnumSet enums(TEST_3, TEST_4);
+ EXPECT_FALSE(enums.Has(TEST_0));
EXPECT_FALSE(enums.Has(TEST_1));
EXPECT_FALSE(enums.Has(TEST_2));
EXPECT_TRUE(enums.Has(TEST_3));
EXPECT_TRUE(enums.Has(TEST_4));
+ EXPECT_FALSE(enums.Has(TEST_5));
}
TEST_F(EnumSetTest, HasAll) {
« no previous file with comments | « chrome/browser/sync/util/enum_set.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698