Issue 8895008: [Sync] Relax EnumSet semantics for some functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8895008: [Sync] Relax EnumSet semantics for some functions (Closed)

Created:
9 years ago by akalin

Modified:
9 years ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing), Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Sync] Relax EnumSet semantics for some functions Clean up some call sites to take advantage of relaxed semantics. Also add comment clarifying usage of EnumSet::Iterator. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113938

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -12 lines)			Patch
M	chrome/browser/sync/engine/get_commit_ids_command.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/engine/nigori_util.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/util/enum_set.h	View	5 chunks	+22 lines, -7 lines	0 comments	Download
M	chrome/browser/sync/util/enum_set_unittest.cc	View	3 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/8895008/1

9 years ago (2011-12-10 01:35:23 UTC) #3

Change committed as 113938

Expand Messages | Collapse Messages