Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 8895005: Remove BrowserAboutHandlerTest.WillHandleBrowserAboutURL suppression. (Closed)

Created:
9 years ago by Reid Kleckner
Modified:
9 years ago
Reviewers:
Timur Iskhodzhanov
CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Remove BrowserAboutHandlerTest.WillHandleBrowserAboutURL suppression. This suppression is too broad, and I can't reproduce the original stack trace I saw anyway, so let's remove this for now and see if it comes up on the bots. TBR=timurrrr@chromium.org BUG=96010 TEST=drm release bot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113844

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M tools/valgrind/drmemory/suppressions.txt View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Reid Kleckner
9 years ago (2011-12-09 19:59:03 UTC) #1
Timur Iskhodzhanov
9 years ago (2011-12-09 21:29:38 UTC) #2
LGTM
09.12.2011 23:59 пользователь <rnk@chromium.org> написал:

> Reviewers: Timur Iskhodzhanov,
>
> Description:
> Remove BrowserAboutHandlerTest.**WillHandleBrowserAboutURL suppression.
>
> This suppression is too broad, and I can't reproduce the original stack
> trace I
> saw anyway, so let's remove this for now and see if it comes up on the
> bots.
>
> TBR=timurrrr@chromium.org
> BUG=96010
> TEST=drm release bot
>
>
> Please review this at
http://codereview.chromium.**org/8895005/<http://codereview.chromium.org/8895...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M tools/valgrind/drmemory/**suppressions.txt
>
>
> Index: tools/valgrind/drmemory/**suppressions.txt
> diff --git a/tools/valgrind/drmemory/**suppressions.txt
> b/tools/valgrind/drmemory/**suppressions.txt
> index e9a9196fa5ba7a5d150a82e8cf9e0e**b229864c29..**
> a4b7d5f45f92d1a6561db17e5222ad**c72bf355cc 100644
> --- a/tools/valgrind/drmemory/**suppressions.txt
> +++ b/tools/valgrind/drmemory/**suppressions.txt
> @@ -204,12 +204,6 @@ name=NPAPITesterBase.**NoHangIfInitCrashes
> deliberate crash
>  # TODO(bruening): switch to annotation once have support for that
>  npapi_test_plugin.dll!**NPAPIClient::PluginClient::**Initialize
>
> -# This test has a death test at the end that derefences a NULL pointer.
> -UNADDRESSABLE ACCESS
> -name=BrowserAboutHandlerTest.**WillHandleBrowserAboutURL deliberate crash
> -...
> -unit_tests.exe!**BrowserAboutHandlerTest_**WillHandleBrowserAboutURL_**
> Test::TestBody
> -
>  # Deliberate NULL deref to crash the child process
>  UNADDRESSABLE ACCESS
>  name=CrashingChildProcess deliberate crash
>
>
>

Powered by Google App Engine
This is Rietveld 408576698