Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: base/message_loop.h

Issue 8894033: Remove MessageLoop::QuitTask. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/message_loop.h
diff --git a/base/message_loop.h b/base/message_loop.h
index 10987032b210e6080e678e65ddc8a89db15d15fc..28ccd4eefa825460b9c3e20b50dc52d0e7c9d49b 100644
--- a/base/message_loop.h
+++ b/base/message_loop.h
@@ -238,26 +238,16 @@ class BASE_EXPORT MessageLoop : public base::MessagePump::Delegate {
// messages. This method may only be called on the same thread that called
// Run, and Run must still be on the call stack.
//
- // Use QuitTask or QuitClosure if you need to Quit another thread's
- // MessageLoop, but note that doing so is fairly dangerous if the target
- // thread makes nested calls to MessageLoop::Run. The problem being that you
- // won't know which nested run loop you are quitting, so be careful!
+ // Use QuitClosure if you need to Quit another thread's MessageLoop, but note
+ // that doing so is fairly dangerous if the target thread makes nested calls
+ // to MessageLoop::Run. The problem being that you won't know which nested
+ // run loop you are quitting, so be careful!
void Quit();
// This method is a variant of Quit, that does not wait for pending messages
// to be processed before returning from Run.
void QuitNow();
- // Invokes Quit on the current MessageLoop when run. Useful to schedule an
- // arbitrary MessageLoop to Quit.
- // TODO(jhawkins): Remove once task.h is removed.
- class QuitTask : public Task {
- public:
- virtual void Run() OVERRIDE {
- MessageLoop::current()->Quit();
- }
- };
-
// Invokes Quit on the current MessageLoop when run. Useful to schedule an
// arbitrary MessageLoop to Quit.
static base::Closure QuitClosure();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698