Remove MessageLoop::QuitTask.

Remove MessageLoop::QuitTask.

BUG=none
TEST=compiles

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113958

[dcheng, 2011-12-10 19:06:23]

I did a make all locally, and there don't seem to be any more references to it.

[Nico, 2011-12-10 19:28:02]

LGTM.

I'd lgtm on rietveld, but it 500s :-/

On Sat, Dec 10, 2011 at 11:06 AM,  <dcheng@chromium.org> wrote:
> Reviewers: Nico,
>
> Message:
> I did a make all locally, and there don't seem to be any more references to
> it.
>
> Description:
> Remove MessageLoop::QuitTask.
>
> BUG=none
> TEST=compiles
>
>
> Please review this at http://codereview.chromium.org/8894033/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M base/message_loop.h
>
>
> Index: base/message_loop.h
> diff --git a/base/message_loop.h b/base/message_loop.h
> index
>
10987032b210e6080e678e65ddc8a89db15d15fc..28ccd4eefa825460b9c3e20b50dc52d0e7c9d49b
> 100644
> --- a/base/message_loop.h
> +++ b/base/message_loop.h
> @@ -238,26 +238,16 @@ class BASE_EXPORT MessageLoop : public
> base::MessagePump::Delegate {
>   // messages.  This method may only be called on the same thread that
> called
>   // Run, and Run must still be on the call stack.
>   //
> -  // Use QuitTask or QuitClosure if you need to Quit another thread's
> -  // MessageLoop, but note that doing so is fairly dangerous if the target
> -  // thread makes nested calls to MessageLoop::Run.  The problem being that
> you
> -  // won't know which nested run loop you are quitting, so be careful!
> +  // Use QuitClosure if you need to Quit another thread's MessageLoop, but
> note
> +  // that doing so is fairly dangerous if the target thread makes nested
> calls
> +  // to MessageLoop::Run.  The problem being that you won't know which
> nested
> +  // run loop you are quitting, so be careful!
>   void Quit();
>
>   // This method is a variant of Quit, that does not wait for pending
> messages
>   // to be processed before returning from Run.
>   void QuitNow();
>
> -  // Invokes Quit on the current MessageLoop when run.  Useful to schedule
> an
> -  // arbitrary MessageLoop to Quit.
> -  // TODO(jhawkins): Remove once task.h is removed.
> -  class QuitTask : public Task {
> -   public:
> -    virtual void Run() OVERRIDE {
> -      MessageLoop::current()->Quit();
> -    }
> -  };
> -
>   // Invokes Quit on the current MessageLoop when run. Useful to schedule an
>   // arbitrary MessageLoop to Quit.
>   static base::Closure QuitClosure();
>
>