Issue 8894030: MIPS: Support Smi->Double->HeapObject transitions in constructed Arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8894030: MIPS: Support Smi->Double->HeapObject transitions in constructed Arrays. (Closed)

Created:
9 years ago by kalmard

Modified:
9 years ago

Reviewers:
kisg, Paul Lind, danno

CC:
v8-dev

Visibility:
Public.

More Reviews

Description

MIPS: Support Smi->Double->HeapObject transitions in constructed Arrays. Port r10218 (1f42dff). Original commit message: Also several bugs with Smi/double elements handling and make Ensure* routines more flexible. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=10282

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	src/mips/builtins-mips.cc	View		1 chunk	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kalmard

Building v8 on MIPS requires the following patch to be landed first: http://codereview.chromium.org/8896022/

9 years ago (2011-12-10 13:35:55 UTC) #1

LGTM

Expand Messages | Collapse Messages