Issue 8894023: Simplify PRTimeToBaseTime implementation, add BaseTimeToPRTime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8894023: Simplify PRTimeToBaseTime implementation, add BaseTimeToPRTime. (Closed)

Created:
9 years ago by mattm

Modified:
9 years ago

Reviewers:
wtc

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Simplify PRTimeToBaseTime implementation, add BaseTimeToPRTime. BUG=107047 TEST=crypto_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114499

Patch Set 2 : test nit #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -16 lines)			Patch
M	crypto/crypto.gyp	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	crypto/nss_util.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	crypto/nss_util.cc	View		1 chunk	+6 lines, -16 lines	0 comments	Download
A	crypto/nss_util_unittest.cc	View	1	1 chunk	+40 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

wtc

LGTM. http://codereview.chromium.org/8894023/diff/1/crypto/nss_util_unittest.cc File crypto/nss_util_unittest.cc (right): http://codereview.chromium.org/8894023/diff/1/crypto/nss_util_unittest.cc#newcode36 crypto/nss_util_unittest.cc:36: BaseTimeToPRTime(base::Time::FromUTCExploded(exploded))); Nit: save PR_ImplodeTime(&prxtime) and base::Time::FromUTCExploded(exploded) in local ...

9 years ago (2011-12-13 00:06:08 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mattm@chromium.org/8894023/5001

9 years ago (2011-12-14 20:56:25 UTC) #3

Change committed as 114499

Expand Messages | Collapse Messages

Issue 8894023: Simplify PRTimeToBaseTime implementation, add BaseTimeToPRTime. (Closed)

Description

Patch Set 1 #

Patch Set 2 : test nit #

Messages