Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: chrome/browser/extensions/extension_host.cc

Issue 8894021: Ensure ExtensionHost sets the RendererPrefs for its TabContents. This fixes a (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_host.cc
diff --git a/chrome/browser/extensions/extension_host.cc b/chrome/browser/extensions/extension_host.cc
index e1c414a474ee73de126aee52472428c1ad845cc1..d40d0951154326e2da64c3d041d30382f197e218 100644
--- a/chrome/browser/extensions/extension_host.cc
+++ b/chrome/browser/extensions/extension_host.cc
@@ -17,6 +17,7 @@
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_tab_util.h"
#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/renderer_preferences_util.h"
#include "chrome/browser/ui/app_modal_dialogs/message_box_handler.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_list.h"
@@ -133,6 +134,12 @@ ExtensionHost::ExtensionHost(const Extension* extension,
TabContentsObserver::Observe(host_contents_.get());
host_contents_->set_delegate(this);
host_contents_->set_view_type(host_type);
+
+ // TODO(mpcomplete): This was lifted from PrefsTabHelper, but it might be
+ // better to reuse all of PrefsTabHelper. We'd first have to make it not
+ // depend on TabContentsWrapper.
+ renderer_preferences_util::UpdateFromSystemSettings(
+ host_contents_->GetMutableRendererPrefs(), profile_);
render_view_host_ = host_contents_->render_view_host();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698