Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: ui/aura/window.h

Issue 8894018: Move the concept of Activation to the Shell. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/aura/test/test_window_delegate.cc ('k') | ui/aura/window.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/aura/window.h
===================================================================
--- ui/aura/window.h (revision 114022)
+++ ui/aura/window.h (working copy)
@@ -92,14 +92,6 @@
// Returns the window's bounds in screen coordinates.
gfx::Rect GetScreenBounds() const;
- // Activates this window. Only top level windows can be activated. Requests
- // to activate a non-top level window are ignored.
- void Activate();
-
- // Deactivates this window. Only top level windows can be
- // deactivated. Requests to deactivate a non-top level window are ignored.
- void Deactivate();
-
// Returns true if this window is active.
bool IsActive() const;
@@ -135,9 +127,6 @@
// |other|.
void StackChildAbove(Window* child, Window* other);
- // Returns true if this window can be activated.
- bool CanActivate() const;
-
// Tree operations.
// TODO(beng): Child windows are currently not owned by the hierarchy. We
// should change this.
@@ -248,7 +237,8 @@
// Sets the window property |value| for given |name|. Setting NULL or 0
// removes the property. It uses |ui::ViewProp| to store the property.
- // Please see the description of |prop_map_| for more details.
+ // Please see the description of |prop_map_| for more details. The caller is
+ // responsible for the lifetime of any object set as a property on the Window.
void SetProperty(const char* name, void* value);
void SetIntProperty(const char* name, int value);
« no previous file with comments | « ui/aura/test/test_window_delegate.cc ('k') | ui/aura/window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698