Issue 8894007: Added comments to setlocale call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8894007: Added comments to setlocale call. (Closed)

Created:
9 years ago by Emmanuel Saint-loubert-Bié

Modified:
9 years ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Added comments to setlocale call. BUG=106725 TEST=RTLTest.WrapPathWithLTRFormatting on Aura/Linux. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113853

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	base/test/test_suite.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Emmanuel Saint-loubert-Bié

Hi, Here is the comment you requested. If this looks good to you can you ...

9 years ago (2011-12-09 17:00:47 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/saintlou@chromium.org/8894007/1

9 years ago (2011-12-09 17:45:16 UTC) #3

commit-bot: I haz the power

9 years ago (2011-12-09 21:40:52 UTC) #4

Try job failure for 8894007-1 (retry) (retry) on win_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Expand Messages | Collapse Messages