Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: chrome/browser/profiles/gaia_info_update_service.cc

Issue 8894005: Ensure that use of GAIA names are considered when handling desktop shortcut changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: beefed comment Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/profiles/profile_info_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/profiles/gaia_info_update_service.cc
===================================================================
--- chrome/browser/profiles/gaia_info_update_service.cc (revision 114091)
+++ chrome/browser/profiles/gaia_info_update_service.cc (working copy)
@@ -131,8 +131,14 @@
// preference guards against clobbering the user's custom settings.
if (!cache.GetHasMigratedToGAIAInfoOfProfileAtIndex(profile_index)) {
cache.SetHasMigratedToGAIAInfoOfProfileAtIndex(profile_index, true);
+ // Order matters here for shortcut management, like in
+ // ProfileShortcutManagerWin::OnProfileAdded, as the picture update does not
+ // allow us to change the target, so we have to apply any renaming first. We
+ // also need to re-fetch the index, as SetIsUsingGAIANameOfProfileAtIndex
+ // may alter it.
+ cache.SetIsUsingGAIANameOfProfileAtIndex(profile_index, true);
+ profile_index = cache.GetIndexOfProfileWithPath(profile_->GetPath());
cache.SetIsUsingGAIAPictureOfProfileAtIndex(profile_index, true);
- cache.SetIsUsingGAIANameOfProfileAtIndex(profile_index, true);
}
}
« no previous file with comments | « no previous file | chrome/browser/profiles/profile_info_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698