Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 8894004: Remove duplicate arguments from hoisted functions. (Closed)

Created:
9 years ago by zundel
Modified:
9 years ago
Reviewers:
codefu
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove duplicate arguments from hoisted functions. See example Dart code that tickles this problem here: http://code.google.com/p/dart/issues/detail?id=565 Committed: https://code.google.com/p/dart/source/detail?r=2315

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed extraneous call to getParms() leftover from debugging #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -18 lines) Patch
M compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java View 1 11 chunks +19 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
zundel
9 years ago (2011-12-09 16:40:49 UTC) #1
codefu
http://codereview.chromium.org/8894004/diff/1/compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java File compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java (right): http://codereview.chromium.org/8894004/diff/1/compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java#newcode2982 compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java:2982: x.getFunction().getParams(); Leftover debug?
9 years ago (2011-12-09 16:42:55 UTC) #2
zundel
http://codereview.chromium.org/8894004/diff/1/compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java File compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java (right): http://codereview.chromium.org/8894004/diff/1/compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java#newcode2982 compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java:2982: x.getFunction().getParams(); On 2011/12/09 16:42:55, codefu wrote: > Leftover debug? ...
9 years ago (2011-12-09 16:47:45 UTC) #3
codefu
9 years ago (2011-12-09 16:48:40 UTC) #4
LGTM

On 2011/12/09 16:47:45, zundel wrote:
>
http://codereview.chromium.org/8894004/diff/1/compiler/java/com/google/dart/c...
> File
> compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java
> (right):
> 
>
http://codereview.chromium.org/8894004/diff/1/compiler/java/com/google/dart/c...
>
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java:2982:
> x.getFunction().getParams();
> On 2011/12/09 16:42:55, codefu wrote:
> > Leftover debug?
> 
> That's exactly what it was.  Removed.

Powered by Google App Engine
This is Rietveld 408576698