Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 8894003: Fix crasher if onBeforeSendHeaders contains no new headers (Closed)

Created:
9 years ago by battre
Modified:
9 years ago
Reviewers:
Matt Perry
CC:
chromium-reviews, jstritar+watch_chromium.org, Aaron Boodman, mihaip+watch_chromium.org
Visibility:
Public.

Description

Fix crasher if onBeforeSendHeaders contains no new headers BUG=104046 TEST=run webrequest extension with chrome.webRequest.onBeforeSendHeaders.addListener(function(details) {return {cancel: true};}, {urls: ["<all_urls>"]}, ["blocking"]); Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113901

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -14 lines) Patch
M chrome/browser/extensions/extension_webrequest_api_helpers.cc View 1 chunk +18 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
battre
Please review. Thanks.
9 years ago (2011-12-09 16:25:08 UTC) #1
Matt Perry
lgtm
9 years ago (2011-12-09 19:50:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/8894003/1
9 years ago (2011-12-09 20:19:10 UTC) #3
commit-bot: I haz the power
Try job failure for 8894003-1 (retry) on linux_rel for step "ui_tests". It's a second try, ...
9 years ago (2011-12-09 22:28:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/8894003/1
9 years ago (2011-12-09 23:01:44 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-10 00:49:43 UTC) #6
Change committed as 113901

Powered by Google App Engine
This is Rietveld 408576698