Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 8894002: Clean up base::android::Init/GetApplicationContext() (Closed)

Created:
9 years ago by Steve Block
Modified:
9 years ago
Reviewers:
bulach, brettw
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Clean up base::android::Init/GetApplicationContext() - Modify InitApplicationContext() to take a ScopedJavaRef - Clarify documentation Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114010

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M base/android/jni_android.h View 2 chunks +9 lines, -5 lines 0 comments Download
M base/android/jni_android.cc View 3 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Steve Block
9 years ago (2011-12-09 15:24:50 UTC) #1
brettw
OWNERS review LGTM, but this is not a real review. I do not understand this ...
9 years ago (2011-12-10 00:05:10 UTC) #2
bulach
LGTM thanks! brettw: would it make sense for us to setup an owners for base/android, ...
9 years ago (2011-12-10 01:21:52 UTC) #3
brettw
It's common for the best people to review something to be different than the people ...
9 years ago (2011-12-10 16:32:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/8894002/1
9 years ago (2011-12-12 10:52:49 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-12 12:33:38 UTC) #6
Change committed as 114010

Powered by Google App Engine
This is Rietveld 408576698