Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 8893019: Fix loss of mouse events when an Aura combobox is open in a modal dialog (Closed)

Created:
9 years ago by benrg
Modified:
9 years ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Fix loss of mouse events when an Aura combobox is open in a modal dialog. NativeComboboxViews was not passing itself as a (transient) parent to MenuRunner::RunMenuAt. All mouse events were sent to the open menu (since it is set as the capture window), and ModalityEventFilter::PreHandleMouseEvent dropped them all since they were not directed to a child of the active modal dialog. BUG=105155 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113978

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/views/controls/combobox/native_combobox_views.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
benrg
ben, this one-line change appears to fix issue 105155, which I asked you about earlier ...
9 years ago (2011-12-10 00:10:54 UTC) #1
Ben Goodger (Google)
lgtm
9 years ago (2011-12-11 21:54:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benrg@chromium.org/8893019/1
9 years ago (2011-12-12 00:29:53 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-12 03:04:25 UTC) #4
Change committed as 113978

Powered by Google App Engine
This is Rietveld 408576698