Issue 8893010: GTK: Speculative fix for crash in BalloonViewHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8893010: GTK: Speculative fix for crash in BalloonViewHost. (Closed)

Created:
9 years ago by Elliot Glaysher

Modified:
9 years ago

Reviewers:
Lei Zhang

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

GTK: Speculative fix for crash in BalloonViewHost. The comments on both methods I'm checking point out that they need to be NULL checked. Hopefully, adding the NULL checks fixes the crashes. BUG=107015 TEST=push to M17, see if it fixes crash in wild. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113890

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	chrome/browser/ui/gtk/notifications/balloon_view_host_gtk.cc	View		1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8893010/1

9 years ago (2011-12-09 21:17:18 UTC) #3

Change committed as 113890

Expand Messages | Collapse Messages