Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 8893007: Fix test that broke in earlier CL. (Closed)

Created:
9 years ago by der Springer
Modified:
9 years ago
Reviewers:
mball, noelallen1, Matt Ball
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Fix test that broke in earlier CL. BUG=none TEST=run_all_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113839

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -9 lines) Patch
M native_client_sdk/src/build_tools/tests/naclsdk_manifest_test.json View 4 chunks +37 lines, -3 lines 1 comment Download
M native_client_sdk/src/build_tools/tests/sdk_update_test.py View 6 chunks +6 lines, -6 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
der Springer
9 years ago (2011-12-09 19:37:00 UTC) #1
Matt Ball
LGTM http://codereview.chromium.org/8893007/diff/1/native_client_sdk/src/build_tools/tests/naclsdk_manifest_test.json File native_client_sdk/src/build_tools/tests/naclsdk_manifest_test.json (right): http://codereview.chromium.org/8893007/diff/1/native_client_sdk/src/build_tools/tests/naclsdk_manifest_test.json#newcode128 native_client_sdk/src/build_tools/tests/naclsdk_manifest_test.json:128: "url": "file:///Users/dspringer/Source/chromium/src/native_client_sdk/src/build_tools/tests/pepper_1_0/naclsdk_win.exe", I realize now that I created ...
9 years ago (2011-12-09 19:40:55 UTC) #2
Pam (message me for reviews)
Drive-by: please make the log comment a little more descriptive. Which test? Thanks, - Pam
9 years ago (2011-12-12 08:02:19 UTC) #3
Matt Ball
9 years ago (2011-12-12 14:12:46 UTC) #4
I think test should be None.  This was just an internal unit test and doesn't
require further testing by QA.

Powered by Google App Engine
This is Rietveld 408576698