Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Issue 8892025: Reland r113741: Move {Restore,Store}FocusedView to NativeWidgetAura::On{Activated,LostActive} (Closed)

Created:
9 years ago by oshima
Modified:
9 years ago
CC:
chromium-reviews, tfarina, ben+watch_chromium.org
Visibility:
Public.

Description

Clear focused view if the focused view is in a window that is being destroyed. Original CL (http://codereview.chromium.org/8821004/) was causing crash on some of browser_tests due to this. BUG=104361 TEST=manual, and browser_tests now pass without crash Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114131

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M ui/views/widget/native_widget_aura.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M ui/views/widget/widget.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
oshima
9 years ago (2011-12-12 18:19:18 UTC) #1
Ben Goodger (Google)
lgtm
9 years ago (2011-12-12 23:23:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/8892025/1
9 years ago (2011-12-12 23:25:10 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-13 00:30:19 UTC) #4
Change committed as 114131

Powered by Google App Engine
This is Rietveld 408576698