chrome/browser/visitedlink/visitedlink_master.cc - Issue 8892023: Eliminated the last few uses of MessageLoop::QuitTask in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/visitedlink/visitedlink_master.cc

Issue 8892023: Eliminated the last few uses of MessageLoop::QuitTask in chrome/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: One more... Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/visitedlink/visitedlink_master.cc

diff --git a/chrome/browser/visitedlink/visitedlink_master.cc b/chrome/browser/visitedlink/visitedlink_master.cc

index 50a824857da50e20bdf6a85d8365ee7163141783..f3fbc859703dbe102c00336b74ad85cc457fcb85 100644

--- a/chrome/browser/visitedlink/visitedlink_master.cc

+++ b/chrome/browser/visitedlink/visitedlink_master.cc

@@ -847,9 +847,9 @@ void VisitedLinkMaster::OnTableRebuildComplete(

table_builder_ = NULL; // Will release our reference to the builder.

// Notify the unit test that the rebuild is complete (will be NULL in prod.)

- if (rebuild_complete_task_.get()) {

- rebuild_complete_task_->Run();

- rebuild_complete_task_.reset(NULL);

+ if (!rebuild_complete_task_.is_null()) {

+ rebuild_complete_task_.Run();

+ rebuild_complete_task_.Reset();

}