Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: chrome/browser/history/history_backend.h

Issue 8892023: Eliminated the last few uses of MessageLoop::QuitTask in chrome/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: One more... Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history.cc ('k') | chrome/browser/history/history_backend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_backend.h
diff --git a/chrome/browser/history/history_backend.h b/chrome/browser/history/history_backend.h
index 9600df121dab526fb247e71091d781bb1dd2b53a..23ac69c5dde82ca8172636deac436edbe8f0fbf1 100644
--- a/chrome/browser/history/history_backend.h
+++ b/chrome/browser/history/history_backend.h
@@ -334,7 +334,8 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
// Sets the task to run and the message loop to run it on when this object
// is destroyed. See HistoryService::SetOnBackendDestroyTask for a more
// complete description.
- void SetOnBackendDestroyTask(MessageLoop* message_loop, Task* task);
+ void SetOnBackendDestroyTask(MessageLoop* message_loop,
+ const base::Closure& task);
// Adds the given rows to the database if it doesn't exist. A visit will be
// added for each given URL at the last visit time in the URLRow if the
@@ -615,9 +616,9 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
// Timestamp of the first entry in our database.
base::Time first_recorded_time_;
- // When non-NULL, this is the task that should be invoked on
+ // When set, this is the task that should be invoked on destruction.
MessageLoop* backend_destroy_message_loop_;
- Task* backend_destroy_task_;
+ base::Closure backend_destroy_task_;
// Tracks page transition types.
VisitTracker tracker_;
« no previous file with comments | « chrome/browser/history/history.cc ('k') | chrome/browser/history/history_backend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698