Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Issue 8892021: Try to address flaxy IndexedDB pyauto tests. (Closed)

Created:
9 years ago by jsbell
Modified:
9 years ago
Reviewers:
hans, dgrogan, Nirnimesh
CC:
chromium-reviews, Nirnimesh, John Grabowski, anantha, dyu1, Paweł Hajdan Jr., dennis_jeffrey
Visibility:
Public.

Description

Try to address flaxy IndexedDB pyauto tests. Databases are deleted before starting tests, to ensure nothing remains from previous runs. Test results are communicated back via document.title to avoid trying to read back a value by injecting script into a process that's busy-looping. Test phases are explicitly triggered by the caller in all cases, rather than relying on previous test state. BUG=103456 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114471

Patch Set 1 #

Total comments: 1

Patch Set 2 : Don't need lambda expressions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -111 lines) Patch
M chrome/test/data/indexeddb/bug_90635.js View 1 chunk +61 lines, -32 lines 0 comments Download
M chrome/test/data/indexeddb/version_change_crash.js View 1 chunk +75 lines, -47 lines 0 comments Download
M chrome/test/functional/PYAUTO_TESTS View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/functional/indexeddb.py View 1 2 chunks +17 lines, -30 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jsbell
nirnimesh@ can you take a look? This addressed the intermittent fails I was seeing when ...
9 years ago (2011-12-09 23:45:54 UTC) #1
Nirnimesh
LGTM http://codereview.chromium.org/8892021/diff/1/chrome/test/functional/indexeddb.py File chrome/test/functional/indexeddb.py (right): http://codereview.chromium.org/8892021/diff/1/chrome/test/functional/indexeddb.py#newcode24 chrome/test/functional/indexeddb.py:24: self.assertTrue(self.WaitUntil(lambda: self.GetActiveTabTitle(), nit: lambda not needed. self.GetActiveTabTitle (without ...
9 years ago (2011-12-13 01:57:56 UTC) #2
jsbell
9 years ago (2011-12-13 19:03:37 UTC) #3
On 2011/12/13 01:57:56, Nirnimesh wrote:
> nit: lambda not needed.
> self.GetActiveTabTitle (without the parens) is already a functional.

Ah yes, thanks.

Will land this when I'm "at home" tomorrow and can watch it more closely.

Powered by Google App Engine
This is Rietveld 408576698