Issue 8892015: Fix chromedriver test extensions to use manifest version 2 and not inline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8892015: Fix chromedriver test extensions to use manifest version 2 and not inline (Closed)

Created:
9 years ago by kkania

Modified:
9 years ago

Reviewers:
Evan Stade

CC:
chromium-reviews, jstritar+watch_chromium.org, Aaron Boodman, kkania, mihaip+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix chromedriver test extensions to use manifest version 2 and not inline scripts. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113872

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -23 lines)			Patch
M	chrome/test/webdriver/test/infobar_browser_action_extension/bg.html	View		1 chunk	+1 line, -18 lines	0 comments	Download
A	chrome/test/webdriver/test/infobar_browser_action_extension/bg.js	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download
M	chrome/test/webdriver/test/infobar_browser_action_extension/manifest.json	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/webdriver/test/page_action_extension/bg.html	View		1 chunk	+1 line, -5 lines	0 comments	Download
A	chrome/test/webdriver/test/page_action_extension/bg.js	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/test/webdriver/test/page_action_extension/manifest.json	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

9 years ago (2011-12-09 22:37:36 UTC) #2

lgtm

http://codereview.chromium.org/8892015/diff/1/chrome/test/webdriver/test/info...
File chrome/test/webdriver/test/infobar_browser_action_extension/bg.js (right):

http://codereview.chromium.org/8892015/diff/1/chrome/test/webdriver/test/info...
chrome/test/webdriver/test/infobar_browser_action_extension/bg.js:1: var
g_infobarReady = false;
license header on js files

Expand Messages | Collapse Messages