Issue 8892012: Define kValidUserScriptSchemes in the .h file so that it can be

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8892012: Define kValidUserScriptSchemes in the .h file so that it can be (Closed)

Created:
9 years ago by Nico

Modified:
9 years ago

Reviewers:
asargent_no_longer_on_chrome

CC:
chromium-reviews, jstritar+watch_chromium.org, Aaron Boodman, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Define kValidUserScriptSchemes in the .h file so that it can be evaluated at compile time in extension.cc. Removes 1 static initializer on both linux and mac. BUG=94925 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113880

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -7 lines)			Patch
	M	chrome/common/extensions/user_script.h	View		2 chunks	+6 lines, -2 lines	0 comments	Download
	M	chrome/common/extensions/user_script.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 2 (0 generated)

commit-bot: I haz the power

9 years ago (2011-12-09 22:18:00 UTC) #2

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/8892012/1