Issue 8892006: Fix reentrancy bug in NetInternalsTest.NetInternalsDnsViewIncognitoClears.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8892006: Fix reentrancy bug in NetInternalsTest.NetInternalsDnsViewIncognitoClears. (Closed)

Created:
9 years ago by mmenke

Modified:
9 years ago

Reviewers:
eroman

CC:
chromium-reviews, eroman, mmenke, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix reentrancy bug in NetInternalsTest.NetInternalsDnsViewIncognitoClears. InProcessBrowserTest::CreateIncognitoBrowser() runs its own message loop as it waits for navigation to complete, which resulted in a race between the navigation to about:blank completing and trying to close the Incognito browser. BUG=106707 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113898

Patch Set 1 #

Patch Set 2 : Update comments #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -18 lines)			Patch
M	chrome/browser/ui/webui/net_internals_ui_browsertest.cc	View	1	3 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/test/data/webui/net_internals/dns_view.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/webui/net_internals/net_internals_test.js	View	1	2 chunks	+44 lines, -11 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/8892006/2002

9 years ago (2011-12-09 19:32:57 UTC) #3

commit-bot: I haz the power

Try job failure for 8892006-2002 (retry) on mac_rel for step "ui_tests". It's a second try, ...

9 years ago (2011-12-09 22:20:49 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/8892006/2002

9 years ago (2011-12-09 22:27:22 UTC) #5

Change committed as 113898

Expand Messages | Collapse Messages