chrome/common/extensions/manifest.cc - Issue 8890086: Issue 71980: Extensions code should use UTF-16 for user-visible Unicode strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest.cc

Issue 8890086: Issue 71980: Extensions code should use UTF-16 for user-visible Unicode strings (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: '' Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/manifest.cc

===================================================================

--- chrome/common/extensions/manifest.cc (revision 114888)

+++ chrome/common/extensions/manifest.cc (working copy)

@@ -114,7 +114,7 @@

Manifest::Manifest(DictionaryValue* value) : value_(value) {}

Manifest::~Manifest() {}

-bool Manifest::ValidateManifest(std::string* error) const {

+bool Manifest::ValidateManifest(string16* error) const {

Restrictions restrictions = g_restrictions.Get();

Type type = GetType();

@@ -129,7 +129,7 @@

}

if (!restrictions.CanAccessKey(*key, type)) {

- *error = ExtensionErrorUtils::FormatErrorMessage(

+ *error = ExtensionErrorUtils::FormatErrorMessageUTF16(

errors::kFeatureNotAllowed, *key);

return false;

}

« no previous file with comments | « chrome/common/extensions/manifest.h ('k') | chrome/common/extensions/manifest_unittest.cc » ('j') | no next file with comments »