Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3860)

Unified Diff: chrome/browser/extensions/extension_error_reporter.cc

Issue 8890086: Issue 71980: Extensions code should use UTF-16 for user-visible Unicode strings (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_error_reporter.cc
===================================================================
--- chrome/browser/extensions/extension_error_reporter.cc (revision 114888)
+++ chrome/browser/extensions/extension_error_reporter.cc (working copy)
@@ -35,7 +35,7 @@
ExtensionErrorReporter::~ExtensionErrorReporter() {}
-void ExtensionErrorReporter::ReportError(const std::string& message,
+void ExtensionErrorReporter::ReportError(const string16& message,
bool be_noisy) {
// NOTE: There won't be a ui_loop_ in the unit test environment.
if (ui_loop_ && MessageLoop::current() != ui_loop_) {
@@ -58,11 +58,11 @@
if (enable_noisy_errors_ && be_noisy) {
browser::ShowErrorBox(NULL,
UTF8ToUTF16("Extension error"),
- UTF8ToUTF16(message));
+ message);
}
}
-const std::vector<std::string>* ExtensionErrorReporter::GetErrors() {
+const std::vector<string16>* ExtensionErrorReporter::GetErrors() {
return &errors_;
}
« no previous file with comments | « chrome/browser/extensions/extension_error_reporter.h ('k') | chrome/browser/extensions/extension_install_ui.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698