Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: chrome/browser/extensions/extension_browsertest.cc

Issue 8890086: Issue 71980: Extensions code should use UTF-16 for user-visible Unicode strings (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_browsertest.cc
===================================================================
--- chrome/browser/extensions/extension_browsertest.cc (revision 114888)
+++ chrome/browser/extensions/extension_browsertest.cc (working copy)
@@ -216,7 +216,7 @@
virtual void OnInstallSuccess(const Extension* extension, SkBitmap* icon) {}
- virtual void OnInstallFailure(const std::string& error) {}
+ virtual void OnInstallFailure(const string16& error) {}
};
class MockAutoConfirmExtensionInstallUI : public ExtensionInstallUI {
@@ -302,9 +302,9 @@
VLOG(1) << " " << (*it)->id();
VLOG(1) << "Errors follow:";
- const std::vector<std::string>* errors =
+ const std::vector<string16>* errors =
ExtensionErrorReporter::GetInstance()->GetErrors();
- for (std::vector<std::string>::const_iterator iter = errors->begin();
+ for (std::vector<string16>::const_iterator iter = errors->begin();
iter != errors->end(); ++iter)
VLOG(1) << *iter;
« no previous file with comments | « chrome/browser/extensions/crx_installer_browsertest.cc ('k') | chrome/browser/extensions/extension_error_reporter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698