Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6272)

Unified Diff: chrome/browser/extensions/crx_installer.h

Issue 8890086: Issue 71980: Extensions code should use UTF-16 for user-visible Unicode strings (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/crx_installer.h
===================================================================
--- chrome/browser/extensions/crx_installer.h (revision 114888)
+++ chrome/browser/extensions/crx_installer.h (working copy)
@@ -199,10 +199,10 @@
// Called after OnUnpackSuccess as a last check to see whether the install
// should complete.
- bool AllowInstall(const Extension* extension, std::string* error);
+ bool AllowInstall(const Extension* extension, string16* error);
// SandboxedExtensionUnpackerClient
- virtual void OnUnpackFailure(const std::string& error_message) OVERRIDE;
+ virtual void OnUnpackFailure(const string16& error_message) OVERRIDE;
virtual void OnUnpackSuccess(const FilePath& temp_dir,
const FilePath& extension_dir,
const base::DictionaryValue* original_manifest,
@@ -221,8 +221,8 @@
void CompleteInstall();
// Result reporting.
- void ReportFailureFromFileThread(const std::string& error);
- void ReportFailureFromUIThread(const std::string& error);
+ void ReportFailureFromFileThread(const string16& error);
+ void ReportFailureFromUIThread(const string16& error);
void ReportSuccessFromFileThread();
void ReportSuccessFromUIThread();
void NotifyCrxInstallComplete(const Extension* extension);
« no previous file with comments | « chrome/browser/extensions/convert_user_script_unittest.cc ('k') | chrome/browser/extensions/crx_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698